Performance Improvements: Camera sensor rendering #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed problem of assigning output buffer to RosImageShader for multiple cameras
mackierx111
requested changes
Jul 10, 2023
There was a problem hiding this comment.
@pijaro
Thanks for the implementation. I think it is a good implementation.
I believe that CameraSensor now requires the CameraSensorHolder class (and a call to DoRender()), so I would like to see the documentation on camera sensors updated as well.
https://tier4.github.io/AWSIM/Components/Sensors/CameraSensor/
|
@szylis Could you look into the documentation and update it? |
|
@mackierx111 @pijaro |
|
I will resolve conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.