Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support compressed image #305

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Support compressed image #305

wants to merge 1 commit into from
+97 −15

Conversation

TakanoTaiga
Copy link
Member

This pull request includes the following changes:

  • Adds an option to select compressed images when publishing camera images.
  • Modifies the shader to prevent the image from flipping during compression.

With this PR, the publish rate will increase from around 10 FPS to nearly 30 FPS.

image

@mackierx111 mackierx111 self-requested a review June 3, 2024 07:45
@mackierx111
Copy link
Collaborator

@TakanoTaiga
Thanks for the pull request.
When I publish in my local environment with Compressed, I get a Vulkan - Out of memory! error in UnityEditor. Have you ever encountered it? Can you tell us what GPU you are using?
image (38)

@TakanoTaiga
Copy link
Member Author

@mackierx111
Tested in the following environments. Not tested on Ubuntu.

  • Windows 10 + DX12
  • RTX3080 Laptop
  • i7 11800H
  • 32GB Memory

@mackierx111
Copy link
Collaborator

mackierx111 commented Jun 11, 2024 •
edited
Loading

memo: Change this PR to draft until memory leakage is improved in ubuntu environment

@mackierx111 mackierx111 marked this pull request as draft June 11, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mackierx111 mackierx111 Awaiting requested review from mackierx111

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TakanoTaiga @mackierx111