Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VehicleRos2Input causing SilentError in binary AWSIM #342

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

kielczykowski-rai
Copy link
Contributor

Description

The PR solves the issue of disappearing scenes in AWSIM. The problem happens in binary AWSIM, it was not observed when working in Unity Editor.

Details

When publishing floating values from Autoware to AWSIM, sometimes NaN values are filled in messages, instead of proper numeric values. This causes the built binary to silently unload the scene, without any logging in Unity Player.log file.

How to reproduce

To reproduce the issue:

  • build the AWSIM binary from Unity Editor
  • source the ROS2 workspace containing autoware_auto_msgs
  • in one terminal publish the GearCommand
ros2 topic pub /control/command/gear_cmd  autoware_auto_vehicle_msgs/msg/GearCommand "stamp:
  sec: 0
  nanosec: 0
command: 2" 
  • in second terminal publish the ControlCommand
ros2 topic pub /control/command/control_cmd autoware_auto_control_msgs/msg/AckermannControlCommand "stamp:
  sec: 1722520890
  nanosec: 0
lateral:
  stamp:
    sec: 0
    nanosec: 0
  steering_tire_angle: nan
  steering_tire_rotation_rate: nan
longitudinal:
  stamp:
    sec: 0
    nanosec: 0
  speed: NaN
  acceleration: nan
  jerk: nan" -r 10

The video below shows how the binary behaves before the fix

Before.webm

The video below shows how the binary behaves after the fix

After.webm

Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mackierx111 mackierx111 merged commit 0ca4970 into main Aug 7, 2024
1 of 2 checks passed
@mackierx111 mackierx111 deleted the fix/ros2_input_nan_values branch August 7, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants