Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lidar): change point cloud format from PointXYZIRCEADT to PointXYZIRCAEDT #357

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

lchojnack
Copy link
Contributor

@lchojnack lchojnack commented Sep 11, 2024

INTERNAL TICKET

Change the point cloud format PointXYZIRCEADT introduced in PR #334 to PointXYZIRCAEDT

Current content of the message:

[sensor_msgs.msg.PointField(name='x', offset=0, datatype=7, count=1),
sensor_msgs.msg.PointField(name='y', offset=4, datatype=7, count=1),
sensor_msgs.msg.PointField(name='z', offset=8, datatype=7, count=1),
sensor_msgs.msg.PointField(name='intensity', offset=12, datatype=2, count=1),
sensor_msgs.msg.PointField(name='return_type', offset=13, datatype=2, count=1), 
sensor_msgs.msg.PointField(name='channel', offset=14, datatype=4, count=1), 
sensor_msgs.msg.PointField(name='azimuth', offset=16, datatype=7, count=1), 
sensor_msgs.msg.PointField(name='elevation', offset=20, datatype=7, count=1), 
sensor_msgs.msg.PointField(name='distance', offset=24, datatype=7, count=1), 
sensor_msgs.msg.PointField(name='time_stamp', offset=28, datatype=6, count=1)]

Content of the message introduced in PR #334

[sensor_msgs.msg.PointField(name='x', offset=0, datatype=7, count=1),
 sensor_msgs.msg.PointField(name='y', offset=4, datatype=7, count=1),
 sensor_msgs.msg.PointField(name='z', offset=8, datatype=7, count=1),
 sensor_msgs.msg.PointField(name='intensity', offset=12, datatype=2, count=1),
 sensor_msgs.msg.PointField(name='return_type', offset=13, datatype=2, count=1),
 sensor_msgs.msg.PointField(name='channel', offset=14, datatype=4, count=1),
 sensor_msgs.msg.PointField(name='elevation', offset=16, datatype=7, count=1), 
 sensor_msgs.msg.PointField(name='azimuth', offset=20, datatype=7, count=1),
 sensor_msgs.msg.PointField(name='distance', offset=24, datatype=7, count=1),
 sensor_msgs.msg.PointField(name='time_stamp', offset=28, datatype=6, count=1)]

…ZIRCAEDT

Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
Copy link
Collaborator

@YoshinoriTsutake YoshinoriTsutake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshinoriTsutake YoshinoriTsutake merged commit f63b803 into main Sep 11, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants