Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rain and fog simulation features #359

Merged
merged 32 commits into from
Oct 1, 2024
Merged

Conversation

PiotrMrozik
Copy link
Contributor

@PiotrMrozik PiotrMrozik commented Sep 23, 2024

This code introduces public components for rain and fog simulations. Each simulation can be controlled with dedicated manager (images below).
image
image

PiotrMrozik and others added 26 commits August 21, 2024 19:34
* Adjust Plugin to new RGL version

* Make skinned models readable

* Add new API calls

* Perform skinning in RGL

* Optimize calculating the pose by caching it for objects that share the same skeleton

* Cleanup & docs

* Update RGL binaries

* Remove unused package import

* Review fixes

* Update RGL binary for Linux
* Make updates to multi-return and snow simulation.

* Remove not used include.

* Update LiDAR prefabs to new multi-return.

* Add updated RGL binary.

* Fix RGL binary.

* Change default setting of LiDAR divergence.

* Update documentation on multi-return.

* Make changes based on review.

* Update RGL binaries (#351)

* Update RGL Linux binary

* Update RGL Windows binary

---------

Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
Co-authored-by: Mateusz Szczygielski <112629916+msz-rai@users.noreply.github.com>
Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
* Make updates to multi-return and snow simulation.

* Remove not used include.

* Update LiDAR prefabs to new multi-return.

* Add updated RGL binary.

* Fix RGL binary.

* Change default setting of LiDAR divergence.

* Update documentation on multi-return.

* Make changes based on review.

* Update RGL binaries (#351)

* Update RGL Linux binary

* Update RGL Windows binary

---------

Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
Co-authored-by: Mateusz Szczygielski <112629916+msz-rai@users.noreply.github.com>
Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
@PawelLiberadzki PawelLiberadzki changed the title Feature/rgl fog simulation Add rain and fog simulation features Sep 23, 2024
Copy link
Contributor

@PawelLiberadzki PawelLiberadzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional note from runtime testing. Except from this, everything seems to work fine in runtime.

Assets/AWSIM/Prefabs/RGLWeatherManager.prefab Outdated Show resolved Hide resolved
@PawelLiberadzki PawelLiberadzki changed the base branch from feature/rgl-24q3 to feature/rgl-multi-return-udp September 25, 2024 13:36
PiotrMrozik and others added 2 commits September 25, 2024 17:15
Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
Copy link
Contributor

@PawelLiberadzki PawelLiberadzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check this feature in the internal repository.

@mackierx111 mackierx111 changed the base branch from feature/rgl-multi-return-udp to main October 1, 2024 12:16
@mackierx111 mackierx111 merged commit 2e50efe into main Oct 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants