Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MinRange, MaxRange in LiDAR prefabs #361

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Fix MinRange, MaxRange in LiDAR prefabs #361

merged 3 commits into from
Oct 17, 2024

Conversation

dmoszynski
Copy link
Contributor

@dmoszynski dmoszynski commented Sep 27, 2024 •
edited by jira bot
Loading

Jira ticket: RJD-1300

Change MinRange, MaxRange in LiDAR prefabs according to this spreadsheet.

Changes include:

  • HesaiPandarXT32: MaxRange: 120 → 80
  • OusterOS1-64: MinRange: 0.8 → 0.5, MaxRange: 120 → 90
  • VelodyneVLS128: MaxRange: 300 → 220
  • HesaiPandar128E4X (OT128): MinRange: ** → 0.3
    x →
    x'

mackierx111
mackierx111 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mackierx111 mackierx111 merged commit e65f2dc into main Oct 17, 2024
1 of 2 checks passed
@mackierx111 mackierx111 deleted the fix/RJD-1300-fix-ranges-in-lidar-prefabs branch October 17, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msz-rai msz-rai msz-rai approved these changes

@mackierx111 mackierx111 mackierx111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmoszynski @mackierx111 @msz-rai