Skip to content

Conversation

@paulsohn
Copy link
Contributor

@paulsohn paulsohn commented Oct 28, 2025

Description

This PR allows to save and load the last selected options (preferences) for initialization_view and ros_topic_view of the intrinsic camera calibrator.

The preferences are saved in $HOME/.config/tier4/intrinsic_camera_calibrator.conf similar to below:

[initialization_view]
board_type=Dot board
data_source=ROS topic
parameter_profile_path=/home/taeseungsohn/workspace/CalibrationTools/install/intrinsic_camera_calibrator/share/intrinsic_camera_calibrator/config/c2_intrinsics_calibrator.yaml

[ros_topic_view]
qos_durability=VOLATILE
qos_reliability=BEST_EFFORT

Note. As the interplay of #267 , the following behavior can be observed:

  • if the user manually selects a board type and then loads a config file, then the board type does not change.
  • however, if the user only has a board type preference set from the previous launch, and has not selected a board type after the most recent launch, then loading a config file changes the board type.

Related links

Saving preferences: #262 #264

Tests performed

Screencast.from.2025.11.04.21.15.43.webm

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@paulsohn paulsohn force-pushed the feat/save-preference-intrinsics branch from 77497a3 to 8bec919 Compare November 4, 2025 08:17
Owen-Liuyuxuan added a commit that referenced this pull request Nov 4, 2025
Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com>
Owen-Liuyuxuan added a commit that referenced this pull request Nov 4, 2025
* feat: fix the board type when it is manually selected

Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com>

* docs: update in-line documentation

Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com>

* changed to use text change function to align with #265

Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com>

---------

Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com>
@paulsohn paulsohn marked this pull request as ready for review November 4, 2025 12:04
Copy link
Contributor

@Owen-Liuyuxuan Owen-Liuyuxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the implementation!

@paulsohn paulsohn merged commit 4912132 into tier4/universe Nov 5, 2025
7 checks passed
@paulsohn paulsohn deleted the feat/save-preference-intrinsics branch November 5, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants