Skip to content

Commit

Permalink
fix(common_sensor_launch): remove duplicate code (#336)
Browse files Browse the repository at this point in the history
* remove duplicate code

Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp>

* ci(pre-commit): autofix

---------

Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
zusizusi and pre-commit-ci[bot] authored Oct 31, 2024
1 parent 03de6c2 commit cd07852
Showing 1 changed file with 0 additions and 31 deletions.
31 changes: 0 additions & 31 deletions common_sensor_launch/launch/nebula_node_container.launch.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,37 +129,6 @@ def create_parameter_dict(*args):
)
)

nodes.append(
ComposableNode(
package="nebula_ros",
plugin=sensor_make + "HwMonitorRosWrapper",
name=sensor_make.lower() + "_hw_monitor_ros_wrapper_node",
parameters=[
{
"sensor_model": sensor_model,
**create_parameter_dict(
"return_mode",
"frame_id",
"scan_phase",
"sensor_ip",
"host_ip",
"data_port",
"gnss_port",
"packet_mtu_size",
"rotation_speed",
"cloud_min_angle",
"cloud_max_angle",
"diag_span",
"dual_return_distance_threshold",
"delay_monitor_ms",
),
},
],
condition=IfCondition(LaunchConfiguration("launch_driver")),
extra_arguments=[{"use_intra_process_comms": LaunchConfiguration("use_intra_process")}],
)
)

# There is an issue where hw_monitor crashes due to data race,
# so the monitor will now only be launched when explicitly specified with a launch command.
launch_hw_monitor: bool = IfCondition(LaunchConfiguration("launch_hw_monitor")).evaluate(
Expand Down

0 comments on commit cd07852

Please sign in to comment.