Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nebula for aip launcher #157

Merged
merged 12 commits into from
Jul 31, 2023
Merged

feat: nebula for aip launcher #157

merged 12 commits into from
Jul 31, 2023

Conversation

drwnz
Copy link
Contributor

@drwnz drwnz commented Jul 23, 2023

Description

This PR adds a universal Nebula launch file for within common_sensor_launch and modifies the Velodyne launch files (VLP16, VLP32C, and VLS128) to use it, as well as adding the Hesai XT32.

It has been tested to work in the XX1 environment using JPT2190 rosbags, and a modified aip_xx1 launcher to use the XT32.

Tested on live sensors (JPT2190), on https://github.com/tier4/pilot-auto.xx1/tree/v0.42.2.0

Related PRs:
AWF Sample Sensor Kit
AWF Autoware
Pilot-Auto.XX1

drwnz and others added 4 commits July 24, 2023 01:50
Signed-off-by: David Wong <david.wong@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
@drwnz drwnz changed the title feat: Nebula for aip_launcher feat: nebula for aip launcher Jul 23, 2023
drwnz and others added 5 commits July 24, 2023 17:16
Signed-off-by: David Wong <david.wong@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
@drwnz drwnz marked this pull request as ready for review July 27, 2023 03:16
@drwnz drwnz marked this pull request as draft July 27, 2023 03:26
…iew angle, increase max view angle to 360

Signed-off-by: David Wong <david.wong@tier4.jp>
@drwnz drwnz marked this pull request as ready for review July 27, 2023 11:55
Signed-off-by: David Wong <david.wong@tier4.jp>
@yukkysaito yukkysaito requested a review from tkimura4 July 31, 2023 07:37
@tkimura4 tkimura4 requested a review from 0x126 July 31, 2023 07:40
@drwnz drwnz enabled auto-merge (squash) July 31, 2023 10:40
Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drwnz drwnz merged commit 5eb758d into tier4/universe Jul 31, 2023
8 of 9 checks passed
@drwnz drwnz deleted the feat/nebula branch July 31, 2023 16:08
@drwnz drwnz restored the feat/nebula branch August 1, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants