Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aip_x1): new sensor configuration #315

Closed
wants to merge 52 commits into from

Conversation

Autumn60
Copy link
Contributor

@Autumn60 Autumn60 commented Sep 17, 2024

諸々の変更をSquashしたPR → #321

1222-takeshi and others added 30 commits September 17, 2024 11:39
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
* fix(diagnostic_aggregator): Modified aggregator confinguration to V1'

* fix path on diagnostic aggregator
fix: add vehicle_velocity_converter.launch to aip_x1_1_launch

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box params in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box param in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Revert crop_box params

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Add cropbox param calc to ground_segmentation.launch.py

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* chore(ground_segmentation): change margin_max_z for cropbox

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>
* feat: use nebula driver for aip_x1_1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* chore: remove comment out

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* chore: remove unnecessary changes

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
1222-takeshi and others added 21 commits September 17, 2024 11:43
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
* change lidar driver to nebula from hesai

Signed-off-by: kotaro-hihara <kotaro.hihara@tier4.jp>

* Set scan_phase 10 deg behind ideal FOVend to prevent dust at the edge of FOV (left,front)

Signed-off-by: kotaro-hihara <kotaro.hihara@tier4.jp>

* ci(pre-commit): autofix

---------

Signed-off-by: kotaro-hihara <kotaro.hihara@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* read callibration from individual_params

Signed-off-by: kotaro-hihara <kotaro.hihara@tier4.jp>

* ci(pre-commit): autofix

---------

Signed-off-by: kotaro-hihara <kotaro.hihara@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…#256)

set use_multithread and use_intra_process to True

Signed-off-by: kotaro-hihara <kotaro.hihara@tier4.jp>
* add enable_blockage_diag argument to lidar.launch.xml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* ci(pre-commit): autofix

---------

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
#253) (#281)

Revert "fix(common_sensor_launch): change vlp16 param (#251) (#253)"

This reverts commit e536068.

Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
* delete unnecessary arg passing

Signed-off-by: Autumn60 <harada.akiro@gmail.com>

* fix gnss_poser param

Signed-off-by: Autumn60 <harada.akiro@gmail.com>

* Adjust gnss launching condition

Signed-off-by: Autumn60 <harada.akiro@gmail.com>

* fix invalid tag usage

Signed-off-by: Autumn60 <harada.akiro@gmail.com>

* ci(pre-commit): autofix

---------

Signed-off-by: Autumn60 <harada.akiro@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
replace use_awsim to use_gnss

Signed-off-by: Autumn60 <harada.akiro@gmail.com>
@Autumn60 Autumn60 marked this pull request as ready for review September 26, 2024 01:48
@Autumn60 Autumn60 removed the request for review from 1222-takeshi September 27, 2024 02:52
@Autumn60 Autumn60 changed the title feat(aip_x1): update new sensor configuration feat(aip_x1): new sensor configuration Sep 27, 2024
@Autumn60 Autumn60 closed this Sep 27, 2024
@Autumn60 Autumn60 deleted the add-XT32-model_rebase_main branch October 8, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants