Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aip_x2_gen2_launch): enbale topic_state_monitor #338

Conversation

kotaro-hihara
Copy link

Enable topic_state_monitor
Verified with lsim that imu_connection diag can be issued.
Jira

Copy link
Contributor

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(aip_x2_launchを参照しにいくのは少し違和感ありますが、共通化できるうちは同じもの使っておいたほうがよさそうなので、差分が出てくるまではこのままで)

@kotaro-hihara kotaro-hihara force-pushed the feat/beta/x2_gen2/v0.29.0/enable_topic_state_monitor branch from 767b32d to b236348 Compare November 6, 2024 00:50
@kotaro-hihara
Copy link
Author

@TomohitoAndo
b236348
topic_state_monitorをaip_x2_gen2_launch内のものを読み込むようにしました(中身はaip_x2_launchと全く同じです)

@TomohitoAndo
Copy link
Contributor

👍
aip_x2_gen2_launch内にも同じファイルあったんですね...。

@kotaro-hihara kotaro-hihara merged commit b9668dd into beta/x2_gen2/v0.29.0 Nov 6, 2024
9 of 10 checks passed
@kotaro-hihara kotaro-hihara deleted the feat/beta/x2_gen2/v0.29.0/enable_topic_state_monitor branch November 6, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants