Skip to content

Commit

Permalink
chore(hesai): apply suggestions for re-wording documentation comments
Browse files Browse the repository at this point in the history
Co-authored-by: David Wong <33114676+drwnz@users.noreply.github.com>
  • Loading branch information
mojomex and drwnz committed Sep 18, 2024
1 parent 0bc2db9 commit 6af4887
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ class HesaiHwInterface
* compensates for the points lost due to the sensor filtering FoV by raw encoder angle.
*
* @param calibration The calibration file of the sensor
* @return Status If the FoV was updated correctly
* @return Status Resulting status of setting the FoV
*/
[[nodiscard]] Status checkAndSetLidarRange(const HesaiCalibrationConfigurationBase & calibration);

Expand Down
2 changes: 1 addition & 1 deletion nebula_ros/include/nebula_ros/hesai/hesai_ros_wrapper.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class HesaiRosWrapper final : public rclcpp::Node

/// @brief The ROS 2 parameter holding the calibration file path is called differently depending
/// on the sensor model. This function returns the correct parameter name given a model.
/// @param model A sensor model
/// @param model The sensor model
/// @return std::string The parameter name
std::string getCalibrationParameterName(drivers::SensorModel model) const;

Expand Down
2 changes: 1 addition & 1 deletion nebula_ros/src/hesai/hesai_ros_wrapper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ nebula::Status HesaiRosWrapper::DeclareAndGetSensorConfigParams()
rcl_interfaces::msg::ParameterDescriptor descriptor = param_read_write();
descriptor.floating_point_range = float_range(0, 360, 0.01);
descriptor.description =
"At which angle to start a new scan. Cannot be equal to the start angle in a non-360 deg "
"Angle at which to cut the scan. Cannot be equal to the start angle in a non-360 deg "
"FoV. Choose the end angle instead.";
config.cut_angle = declare_parameter<double>("cut_angle", descriptor);
}
Expand Down

0 comments on commit 6af4887

Please sign in to comment.