Skip to content

Commit

Permalink
chore(at128): add explanatory comment on why fov bounds are hard-coded
Browse files Browse the repository at this point in the history
  • Loading branch information
mojomex committed Sep 17, 2024
1 parent eaa49f6 commit 7272be2
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions nebula_common/include/nebula_common/hesai/hesai_common.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,10 @@ struct HesaiCorrection : public HesaiCalibrationConfigurationBase
[[nodiscard]] std::tuple<float, float> getFovPadding() const override
{
// TODO(mojomex): calculate instead of hard-coding
// The reason this is tricky is that an upper bound over all azimuth/elevation combinations has
// to be found. For other sensors, this is only a function of elevation, so the search space is
// tiny compared to AT128. We should be able to find an upper bound of `getAzimuthAdjustV3` but
// I have not invested the time for now.
return {-5, 5};
}
};
Expand Down

0 comments on commit 7272be2

Please sign in to comment.