Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix pre-commit config and adapt code to make all checks pass #162

Merged
merged 25 commits into from
Jun 26, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Jun 7, 2024

PR Type

  • Improvement

Description

This PR is a preliminary step to

and makes pre-commit pass on the current codebase.
This involved:

  • fixing the pre-commit configuration (and that of its hooks):
    • revert prettier version from 4.0.0-alpha.8 to 3.1.0
    • disable prettier on yaml and json files (as they are handled by yamllint and clang-format respectively)
    • add clang-format config for json
    • add exception in yamllint for .clang-format as its format is required to be non-standard
  • implementing the code changes flagged by pre-commit hooks
    • whitespace changes
    • import changes
    • copyright notices in cpp/hpp source files
    • quoting changes in yaml files
    • added/removed qualifiers like explicit, override, etc.
    • ...

pre-commit is now passing.

Review Procedure

Make sure to check "hide whitespace" and click apply/reload in the "changed files" view's settings when reviewing:

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Jun 7, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 5.17241% with 55 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@46171bf). Learn more about missing BASE report.

Files Patch % Lines
nebula_ros/src/robosense/decoder_wrapper.cpp 0.00% 32 Missing ⚠️
...src/nebula_decoders_robosense/robosense_driver.cpp 0.00% 4 Missing ⚠️
nebula_ros/src/hesai/hesai_ros_wrapper.cpp 0.00% 3 Missing ⚠️
...s/nebula_decoders_robosense/decoders/bpearl_v3.hpp 0.00% 2 Missing ⚠️
...s/nebula_decoders_robosense/decoders/bpearl_v4.hpp 0.00% 2 Missing ⚠️
...ders/nebula_decoders_robosense/decoders/helios.hpp 0.00% 2 Missing ⚠️
...a_decoders_robosense/decoders/robosense_packet.hpp 0.00% 2 Missing ⚠️
nebula_ros/src/robosense/robosense_ros_wrapper.cpp 0.00% 2 Missing ⚠️
nebula_ros/src/velodyne/velodyne_ros_wrapper.cpp 0.00% 2 Missing ⚠️
nebula_common/src/nebula_common.cpp 0.00% 1 Missing ⚠️
... and 3 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #162   +/-   ##
==========================================
  Coverage           ?   14.13%           
==========================================
  Files              ?       82           
  Lines              ?     7585           
  Branches           ?     1179           
==========================================
  Hits               ?     1072           
  Misses             ?     5679           
  Partials           ?      834           
Flag Coverage Δ
differential 14.13% <5.17%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mojomex added 22 commits June 7, 2024 19:37
…isfy yamllint and ignore them in prettier to prevent conflicting styles
@mojomex mojomex force-pushed the pre-commit-fixes branch 2 times, most recently from 205e156 to c2d15eb Compare June 7, 2024 11:00
@mojomex mojomex requested a review from drwnz June 7, 2024 17:04
@mojomex mojomex mentioned this pull request Jun 17, 2024
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mojomex mojomex merged commit 10725e4 into tier4:develop Jun 26, 2024
8 of 9 checks passed
@mojomex mojomex deleted the pre-commit-fixes branch June 26, 2024 10:19
@mojomex mojomex mentioned this pull request Jul 18, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants