Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clang): make build pass with Clang #166

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Jun 24, 2024

PR Type

  • Improvement
  • Bug Fix

Related Links

Similar PR currently merged in develop:

Description

@veqcc wants to analyze Autoware and Nebula using Clang-tooling, this PR is to make this possible before the (possibly long-winded) merge of develop.

There were two declared, but undefined member functions in the ARS548 HW interfaces that were addressed in

which wouldn't link after compiling with Clang, so I implemented them as printing an error to the console for now (non-breaking change and better than failing silently). @knzo25 please check that this temporary warning is okay.

Fixes #157.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex requested review from knzo25 and veqcc June 24, 2024 13:55
Copy link
Collaborator

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mojomex mojomex merged commit d9aaefc into tier4:main Jun 24, 2024
6 checks passed
@mojomex mojomex deleted the clang-compat-main branch June 24, 2024 14:29
@mojomex mojomex mentioned this pull request Jul 31, 2024
@mojomex mojomex self-assigned this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in EIGEN_ALIGN16
2 participants