fix(clang): make build pass with Clang #166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Similar PR currently merged in
develop
:Description
@veqcc wants to analyze Autoware and Nebula using Clang-tooling, this PR is to make this possible before the (possibly long-winded) merge of
develop
.There were two declared, but undefined member functions in the ARS548 HW interfaces that were addressed in
which wouldn't link after compiling with Clang, so I implemented them as printing an error to the console for now (non-breaking change and better than failing silently). @knzo25 please check that this temporary warning is okay.
Fixes #157.
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks