Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hesai): fix supported return modes for Hesai sensors #188

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Sep 2, 2024

PR Type

  • Bug Fix

Related Links

Description

The supported return modes for some Hesai sensors were not correct:

  • AT128 does not support all return modes Nebula allowed
  • XT32 supports more return modes than Nebula allowed

Return mode Dual is a relic from Velodyne's driver and is kept in Nebula for backwards-compatibility reasons. However, the internal representation has been updated to the more precise, sensor-specific return modes (LastStrongest or LastFirst depending on the sensor).

Review Procedure

Use nebula_evaluation to test return modes on these sensors.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Sep 2, 2024
@mojomex mojomex requested a review from drwnz September 2, 2024 08:40
@mojomex mojomex marked this pull request as ready for review September 3, 2024 01:33
@mojomex mojomex requested a review from knzo25 September 3, 2024 06:35
Copy link
Collaborator

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@mojomex mojomex merged commit 456cb1e into tier4:develop Sep 3, 2024
10 checks passed
@mojomex mojomex deleted the hesai-fix-return-modes branch September 3, 2024 10:02
@mojomex mojomex mentioned this pull request Sep 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants