fix(nebula_launch.py): make the generic launch file hand off to the correct vendor's launch file #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description
The
nebula_launch.py
file was long deprecated but also had incorrect/incomplete launch arguments for some vendors/sensors.This PR re-writes this file such that it only explicitly handles the
sensor_model
argument, finds the corresponding vendor-specific launch file and hands off all remaining arguments to that file.This way, backwards-compatibility is still ensured and future changes to vendor launch files will not necessitate updates to
nebula_launch.py
.Support for containers is purpusefully dropped since the vendor launch files also do not support it anymore. This could be added back in in the future.
Review Procedure
nebula_launch.py
with onlysensor_model
as an argument.config_file
in a different location than the default one (innebula_ros/config
)Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks