Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: create API reference page, link class/namespace/... references in navigation #194

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Sep 10, 2024

PR Type

  • Improvement

Description

This PR should make it much user-friendlier to navigate through the API reference.

image

Review Procedure

Run

python3 -m pip install -U $(curl -fsSL https://raw.githubusercontent.com/autowarefoundation/autoware-github-actions/main/deploy-docs/mkdocs-requirements.txt)
cd src
mkdocs serve

and confirm the API reference tab is working as expected.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!
The only issue I see that "API" is rendered "Api" on the API reference page.
I wonder if it is as simple as renaming the file (although that is ugly in it's own way)...
image

docs/api_reference.md Outdated Show resolved Hide resolved
docs/api_reference.md Outdated Show resolved Hide resolved
docs/api_reference.md Outdated Show resolved Hide resolved
docs/api_reference.md Outdated Show resolved Hide resolved
mojomex and others added 2 commits November 5, 2024 14:20
Co-authored-by: David Wong <33114676+drwnz@users.noreply.github.com>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
@mojomex
Copy link
Collaborator Author

mojomex commented Nov 5, 2024

image

@drwnz Fixed by adding a # API Reference markdown heading manually. MkDocs recognizes that and even uses it in the nav menu now.

@mojomex mojomex merged commit bd62eb1 into tier4:develop Nov 5, 2024
10 checks passed
@mojomex mojomex deleted the develop-docs branch November 5, 2024 05:26
mojomex added a commit that referenced this pull request Nov 8, 2024
…in navigation (#194)

* docs: add API reference page and add things like class references to nav

* Apply suggestions from code review

Co-authored-by: David Wong <33114676+drwnz@users.noreply.github.com>

* docs: fix case style of API reference heading

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>

---------

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Co-authored-by: David Wong <33114676+drwnz@users.noreply.github.com>
mojomex added a commit that referenced this pull request Nov 11, 2024
…or model (#195)

* docs: create API reference page, link class/namespace/... references in navigation (#194)

* docs: add API reference page and add things like class references to nav

* Apply suggestions from code review

Co-authored-by: David Wong <33114676+drwnz@users.noreply.github.com>

* docs: fix case style of API reference heading

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>

---------

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Co-authored-by: David Wong <33114676+drwnz@users.noreply.github.com>

* chore(docs): add `mkdocs_macros.py` for schema table rendering

* docs: add vendor pages for parameters

* docs: add parameter pages for all sensors

* chore(schema): restrict `sensor_model` parameter to only the sensor model in the current schema file

* chore(docs): update requirements.txt to match Autoware

* docs: add docs build instructions to readme

* ci(pre-commit): autofix

* chore(docs): make `include_refs` default

* ci(pre-commit): autofix

* chore(docs): remove empty about page as the index page already contains an about section

* docs: deprecate old point types

* docs: update support status for sensors

* docs: re-arrange nav to reflect user needs better

* docs: document common parameters

* docs: revert status of currently not fully tested sensors

* docs: add figures and more detailed explanation to the scan angle section for Hesai

* English lesson

Co-authored-by: David Wong <33114676+drwnz@users.noreply.github.com>

* chore: apply suggested phrasing changes

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>

* chore: move Hesai-specific parameters to Hesai schema

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>

* docs: add parameter table for Hesai

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>

---------

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Co-authored-by: David Wong <33114676+drwnz@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants