Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exclude build and example folders from coverage #199

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Sep 25, 2024

PR Type

  • Improvement

Related Links

Description

This PR removes the build and nebula_examples folders from code coverage statistics.
The build folder contains the code-generation results from nebula_msgs etc. and should not be included (also, it's 9000 lines 🤯).
The nebula_examples folder is not part of the main functionality of the software and thus, coverage is not important.

Review Procedure

Compare coverage results from before and after given the links above and confirm that

  • the directories are removed
  • all other relevant directories are present and correct

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Sep 25, 2024
mojomex and others added 2 commits September 25, 2024 13:00
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant