-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sync_angle): hesai. Enable Clock Sync Features #39
Conversation
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 13.44% 16.21% +2.77%
==========================================
Files 111 54 -57
Lines 10852 8577 -2275
Branches 1703 1687 -16
==========================================
- Hits 1459 1391 -68
+ Misses 8224 6021 -2203
+ Partials 1169 1165 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on AT128 and Pandar40P. As noted, Pandar40P needs a device restart before settings are applied.
Sync angle settings are working as required.
PR Type
Related Links
https://tier4.atlassian.net/browse/RT1-3110?atlOrigin=eyJpIjoiZjIyZDQ1ODA1NmZmNGQyNWIzOTNmZTg5YzlmMmVhY2MiLCJwIjoiaiJ9
Description
Review Procedure
scan_phase
parameter in the launch file.Remarks
There is a known bug on the Pandar40P where the Lidar only responds to the first TCP command causing timeout on the subsequent commands. The only known way to solve this is to power cycle the Lidar.
NOTE: This won't work with the AT128 since it doesn't support PTP setup through TCP commands.Added support for the AT128 via HTTP.