Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync_angle): hesai. Enable Clock Sync Features #39

Merged
merged 6 commits into from
Jul 30, 2023
Merged

Conversation

amc-nu
Copy link
Contributor

@amc-nu amc-nu commented Jul 24, 2023

PR Type

  • New Feature

Related Links

https://tier4.atlassian.net/browse/RT1-3110?atlOrigin=eyJpIjoiZjIyZDQ1ODA1NmZmNGQyNWIzOTNmZTg5YzlmMmVhY2MiLCJwIjoiaiJ9

Description

  • Sets lidar sync angle on launch on Hesai drivers.
  • Sets PTP as the default clock source
  • Sets PTP config to IEEE1588v2 over UDP/IP as default.

Review Procedure

  • Set a value in the scan_phase parameter in the launch file.
  • Launch the driver.
  • Verify the value has changed using Lidar's web UI.

Remarks

There is a known bug on the Pandar40P where the Lidar only responds to the first TCP command causing timeout on the subsequent commands. The only known way to solve this is to power cycle the Lidar.

NOTE: This won't work with the AT128 since it doesn't support PTP setup through TCP commands.
Added support for the AT128 via HTTP.

Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
@amc-nu amc-nu requested a review from drwnz July 24, 2023 00:28
@amc-nu amc-nu changed the title (feature): hesai. Enable Sync Phase feat(sync_angle): hesai. Enable Sync Phase Jul 24, 2023
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.77 🎉

Comparison is base (a3d2788) 13.44% compared to head (6f4086e) 16.21%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   13.44%   16.21%   +2.77%     
==========================================
  Files         111       54      -57     
  Lines       10852     8577    -2275     
  Branches     1703     1687      -16     
==========================================
- Hits         1459     1391      -68     
+ Misses       8224     6021    -2203     
+ Partials     1169     1165       -4     
Flag Coverage Δ
differential 16.21% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../nebula_hesai_hw_interfaces/hesai_hw_interface.cpp 0.00% <0.00%> (ø)
...ebula_ros/hesai/hesai_hw_interface_ros_wrapper.hpp 0.00% <ø> (ø)
.../nebula_ros/hesai/hesai_hw_monitor_ros_wrapper.hpp 0.00% <ø> (ø)
...ros/velodyne/velodyne_hw_interface_ros_wrapper.hpp 0.00% <ø> (ø)
...a_ros/velodyne/velodyne_hw_monitor_ros_wrapper.hpp 0.00% <ø> (ø)
...a_ros/src/hesai/hesai_hw_interface_ros_wrapper.cpp 0.00% <0.00%> (ø)
...ula_ros/src/hesai/hesai_hw_monitor_ros_wrapper.cpp 0.00% <0.00%> (ø)

... and 57 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amc-nu amc-nu changed the title feat(sync_angle): hesai. Enable Sync Phase feat(sync_angle): hesai. Enable Clock Sync Features Jul 24, 2023
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on AT128 and Pandar40P. As noted, Pandar40P needs a device restart before settings are applied.
Sync angle settings are working as required.

@drwnz drwnz merged commit 2249891 into main Jul 30, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants