fix(nebula_examples): fix lint errors. Add ament_lint dependencies

[esteve]

PR Type

• Bug Fix

Related Links

Description

This PR fixes the lint errors and enables the linters in package.xml

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[esteve]

@amc-nu this PR adds the changes from #65 and also fixes the lint errors in CMake and the C++ code.

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: +2.78% 🎉

Comparison is base (e0d05a7) 13.35% compared to head (c421ffb) 16.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   13.35%   16.14%   +2.78%     
==========================================
  Files         111       54      -57     
  Lines       10989     8672    -2317     
  Branches     1725     1709      -16     
==========================================
- Hits         1468     1400      -68     
+ Misses       8345     6100    -2245     
+ Partials     1176     1172       -4     

Flag	Coverage Δ
differential	16.14% <0.00%> (?)
total	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...es/src/hesai/hesai_ros_offline_extract_bag_pcd.cpp	0.00% <0.00%> (ø)
...c/hesai/hesai_ros_offline_extract_bag_pcd_main.cpp	0.00% <0.00%> (ø)
...amples/src/hesai/hesai_ros_offline_extract_pcd.cpp	0.00% <0.00%> (ø)
...s/src/hesai/hesai_ros_offline_extract_pcd_main.cpp	0.00% <0.00%> (ø)
.../velodyne/velodyne_ros_offline_extract_bag_pcd.cpp	0.00% <0.00%> (ø)
...dyne/velodyne_ros_offline_extract_bag_pcd_main.cpp	0.00% <0.00%> (ø)

... and 57 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[amc-nu]

Thank you for this PR.
We have a few PRs pending. I’m sure linting will cause many errors. Do you suggest any automatic linting tool?
Additionally, I remember linting also caused issues with clang format.
Thanks again

[esteve]

@amc-nu I've used the ones that come with ament_lint, unfortunately some of the lints can't be fixed automatically (e.g. lint_cmake, cpplint), but for formatting I just used ament_uncrustify --reformat

I've noticed that clang-tidy fails, but I don't know if that's a required check.

[amc-nu]

Indeed, we don't enforce clang-tidy since it fails consistently on rclcpp.
If this PR is ready, let me know to proceed with the review.
Thanks

[esteve]

@amc-nu no problem, let me remove the latest changes and then the PR should be ready for review. I was hoping I could fix the clang-tidy issues, but couldn't figure out a way to ignore rclcpp

[esteve]

@amc-nu I've removed all the attempts to fix the clang-tidy issues, this PR is now ready for review.