fix(velodyne): allow setup_sensor False

[amc-nu]

PR Type

• Bug Fix

Description

Allows Velodyne sensors to use sensor_setup:=False regardless of the launch and sensor setup.

Fixes #53

Review Procedure

Launch
ros2 launch nebula_ros velodyne_launch_all_hw.xml sensor_model:=SENSOR setup_sensor:=False

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[codecov-commenter]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (99d3560) 9.93% compared to head (564218e) 7.47%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff            @@
##            main     #75      +/-   ##
========================================
- Coverage   9.93%   7.47%   -2.47%     
========================================
  Files        118      37      -81     
  Lines      10147    6825    -3322     
  Branches    1533    1137     -396     
========================================
- Hits        1008     510     -498     
+ Misses      8034    5375    -2659     
+ Partials    1105     940     -165     

Flag	Coverage Δ
differential	7.47% <0.00%> (?)
total	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...a_velodyne_hw_interfaces/velodyne_hw_interface.cpp	0.00% <ø> (ø)
...src/velodyne/velodyne_hw_interface_ros_wrapper.cpp	0.00% <0.00%> (ø)

... and 81 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mebasoglu]

Hello, I tested it with a VLP-16 and it works. Thank you!