Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update cmake versions to remove build warning #97

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

drwnz
Copy link
Collaborator

@drwnz drwnz commented Nov 16, 2023

PR Type

  • Bug Fix

Related Links

Description

The CMake version specified by most launchfiles results in a build warning, because of undefined cmake_policy for find_package` behaviour. This PR requests a newer version and unifies all CMakeLists.txt throughout the project.

Review Procedure

Simple clean build! Previously, this warning would appear multiple times:

CMake Warning (dev) at CMakeLists.txt:6 (find_package):
Policy CMP0074 is not set: find_package uses _ROOT variables.
Run "cmake --help-policy CMP0074" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.

CMake variable PCL_ROOT is set to:

/usr

For compatibility, CMake is ignoring the variable.
This warning is for project developers. Use -Wno-dev to suppress it.`

This warning should now be gone.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Signed-off-by: David Wong <david.wong@tier4.jp>
@drwnz drwnz requested review from amc-nu and xmfcx November 16, 2023 16:04
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ae8cf5) 8.29% compared to head (2c811c5) 9.57%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #97      +/-   ##
========================================
+ Coverage   8.29%   9.57%   +1.28%     
========================================
  Files         87      51      -36     
  Lines       8455    6958    -1497     
  Branches     852     843       -9     
========================================
- Hits         701     666      -35     
+ Misses      7179    5719    -1460     
+ Partials     575     573       -2     
Flag Coverage Δ
differential 9.57% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drwnz drwnz merged commit a01e2fa into main Nov 16, 2023
7 of 8 checks passed
@drwnz drwnz deleted the chore/cmake_version branch November 16, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants