Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use realistic LiDAR position in simple_sensor_simulator #1235

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

f0reachARR
Copy link
Contributor

@f0reachARR f0reachARR commented Apr 18, 2024

Description

Abstract

Fixes for #1193

Background

As I mentioned at #1227, LiDAR origin passed to Raycaster is too low (Ego bottom), and it detects objects that should be occluded.

Details

To make LiDAR realistic, this PR will change LiDAR position to top of the Ego vehicle.

Before
image

After
image

In the images, pink points are LiDAR scan.
Before this PR, LiDAR is located on the bottom of the vehicle and reads the pedestrian's feet. This is not realistic and detects some objects that should be occluded.
The after image shows that the pedestrian is occluded by npc1 and does not appear in the LiDAR scan results.

Note

In some cases, OccupancyGridSensor emits objects that we thought it was occluded (like images on #1193). This is because simulator converts three dimensions into two-dimensional information.
As research of Autoware probabilistic_occupancy_grid_map, such situation can be happen in real sensor.
In order to mimic Autoware's behavior, I have not excluded such cases.

Destructive changes

LiDAR is repositioned to the top of vehicle.
Because of this change, errors may be seen in some scenarios. Regression test is needed.

Copy link

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@f0reachARR f0reachARR force-pushed the fix/lidar-position-reality branch from f35d70d to 1146f91 Compare April 18, 2024 07:05
@f0reachARR f0reachARR requested a review from hakuturu583 April 18, 2024 08:00
@f0reachARR f0reachARR marked this pull request as ready for review April 18, 2024 08:00
@hakuturu583 hakuturu583 marked this pull request as draft May 1, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants