-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add if
section in the restore branch step of the Release action
#1248
Open
hakuturu583
wants to merge
18
commits into
master
Choose a base branch
from
fix/release_action
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hakuturu583 <ms.kataoka@gmail.com>
hakuturu583
added
the
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
label
May 10, 2024
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
hakuturu583
changed the title
add if section restore branch step in Release action
add May 10, 2024
if
in restore branch step of Release action
hakuturu583
changed the title
add
add May 10, 2024
if
in restore branch step of Release actionif
section in restore branch step of Release action
hakuturu583
changed the title
add
add May 10, 2024
if
section in restore branch step of Release actionif
section in the restore branch step of the Release action
Signed-off-by: hakuturu583 <ms.kataoka@gmail.com>
Signed-off-by: hakuturu583 <ms.kataoka@gmail.com>
… into fix/release_action
I would appreciate it if you could work on this PR in your spare time. |
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
… into fix/release_action
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
This was referenced Sep 18, 2024
… into fix/release_action
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Fixed a bug that caused release actions to fail when an external contributor opened a pull request from a forked repository.
Background
This step is intended to restore a branch that was inadvertently deleted at the same time as a merge, and is set up so that it can work even if there is an operational error.
However, when a pull request is received from an external repository, the branch to be restored does not exist and an error occurs.
Details
I introduced an option to ignore the error so that pull requests from external repositories can be merged.
References
#1242
Destructive Changes
N/A
Known Limitations
N/A