-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve simulated manual override with FollowTrajectoryAction
#1280
Draft
HansRobo
wants to merge
57
commits into
master
Choose a base branch
from
feature/manual_on_follow_trajectory
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…action-nan-time' into feature/manual_on_follow_trajectory
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
…ory' into feature/manual_on_follow_trajectory
HansRobo
added
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
wait for regression test
and removed
wait for regression test
labels
Jul 4, 2024
…ateDispatcher::registerTask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Improve simulated manual override with
FollowTrajectoryAction
Background
In previous version of scenario_simulator_v2, the control mode during the override is still
AUTONOMOUS
.This could not be accurately simulated for manual overrides , so this pull request was created.
Details
Note
This section is copied from
ManualOverrideWithFollowTrajectoryAction.md
in this pull-request.scenario_simulator_v2
simulates the manual override of Autoware, withFollowTrajectoryAction
.During the executing
FollowTrajectoryAction
, the control of the ego entity is taken over from Autoware to theFollowTrajectoryAction
.3 types of override for Autoware
There are 3 types of override for Autoware.
Local
: Manually control the vehicle from nearby with some device such as a joystick. This is one of operation modes.Remote
: Manually control the vehicle from a web application on the cloud. This is one of operation modes.Direct
: Manually control the vehicle from handle, brake and/or accel directly. Please note that this is not a operation mode but a control mode of vehicle interface.override simulation in scenario_simulator_v2
vehicle interface simulation is a part of the ego vehicle simulation feature in
scenario_simulator_v2
.scenario_simulator_v2
simulates aDirect
override triggered by safety operators when a scenario commands overriding the ego vehicle byFollowTrajectoryAction
.3 steps scenario_simulator_v2 takes to simulate the overrides
1. triggering the override
In real vehicle, the override detected in vehicle internally and communicated to vehicle interface node such as
pacmod_interface
node.In
scenario_simulator_v2
,openscenario_interpreter
send an override flag via zmq interface betweentraffic_simulator
andsimple_sensor_simulator
whenFollowTrajectoryAction
is started.simple_sensor_simulator
receives it and set the control mode to MANUAL like vehicle interface do when hardware override triggers detected.2. during the override
traffic_simulator
send ego status calculated to follow described in the scenario andsimple_sensor_simulator
overrides Autoware control with overwriting ego status by the received ego status.3. finishing the override
When
FollowTrajectoryAction
is finished,traffic_simulator
call service to enable autoware control and stop sending the override flag tosimple_sensor_simulator
via zmq communication.This mimics the steps safety operators do in real vehicle via some human interfaces, in API level.
References
Destructive Changes
None
Known Limitations
scenario_simulator_v2
does not support a remote override for now.