Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: [RJD-937] to Implement Unit tests on simple_sensor_simulator #1301

Merged
merged 6 commits into from
Sep 2, 2024
Merged

Test: [RJD-937] to Implement Unit tests on simple_sensor_simulator #1301

merged 6 commits into from
Sep 2, 2024

Conversation

SzymonParapura
Copy link
Contributor

Description

Abstract

This PR contains unit tests for:

  1. LidarSensor and LidarSensorBase
  2. Primitive

Details

  1. update_noEgo
  2. update_correct
  3. update_goBackInTime
  4. getDetectedObjects
  5. addToScene_sample
  6. addToScene_zeros
  7. getTriangles
  8. getVertex
  9. get2DConvexHull_normal
  10. get2DConvexHull_withTransform
  11. getMin
  12. getMin_withTransform
  13. getMin_empty
  14. getMax
  15. getMax_withTransform
  16. getMax_empty

References

Jira ticket: link

Destructive Changes

There are no destructive changes

@SzymonParapura
Test: [RJD-937] to Implement Unit tests on simple_sensor_simulator
2ef0ef3 
 - Added unit tests to LidarSensor
 - Addede unit tests to Primitive
 - Refactored Raycaster unit tests
@SzymonParapura SzymonParapura self-assigned this Jun 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited by hakuturu583
Loading

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@hakuturu583 hakuturu583 requested review from hakuturu583 and removed request for HansRobo July 31, 2024 04:48
hakuturu583
hakuturu583 requested changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@hakuturu583 hakuturu583 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use dummy primitive.

simulation/simple_sensor_simulator/test/src/sensor_simulation/primitives/test_primitive.cpp Show resolved Hide resolved
@hakuturu583 hakuturu583 added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Sep 2, 2024
hakuturu583
hakuturu583 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@hakuturu583 hakuturu583 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Approved!

@hakuturu583 hakuturu583 merged commit 4b4eabb into master Sep 2, 2024
10 checks passed
@github-actions github-actions bot deleted the feature/simple_sensor_simulator_unit_tests_lidar branch September 2, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakuturu583 hakuturu583 hakuturu583 approved these changes

Assignees

@SzymonParapura SzymonParapura

Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SzymonParapura @hakuturu583