Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tmp] RJD-1057 (2/5): Remove non-API member functions: EntityManager’s TrafficLight related member functions (tests) #1336

Conversation

TauTheLepton
Copy link
Contributor

@TauTheLepton TauTheLepton commented Jul 31, 2024

Description

DO NOT MERGE | THIS IS A TEMPORARY PR | WHEN THE RIGHT TIME COMES, A CLONE WILL BE CAST TO MASTER

Abstract

This pull request is a continuation of #1406.
It adds tests for the new implementation of the traffic lights.

Background

This pull request is one of many that aim to modularize the scenario_simulator_v2.

Details

In the previous pull request, a new implementation of traffic lights has been added and tests developed for the previous implementation have been deleted.
This pull request introduces tests for the new implementation of traffic lights. These changes have been split into two PRs, because of the amount of changes. If these changes (this PR and the previous one) were introduced in one PR, it would have been very large (>2000 additions).

References

INTERNAL LINK

Destructive Changes

Known Limitations

This reverts commit 433019c.

Signed-off-by: Mateusz Palczuk <mateusz.palczuk@robotec.ai>
@yamacir-kit yamacir-kit deleted the branch RJD-1057-remove-traffic-lights-from-entity-manager September 18, 2024 01:40
@yamacir-kit yamacir-kit deleted the RJD-1057-traffic-lights-tests branch September 18, 2024 01:41
@TauTheLepton TauTheLepton restored the RJD-1057-traffic-lights-tests branch October 2, 2024 07:32
@TauTheLepton TauTheLepton reopened this Oct 2, 2024
@TauTheLepton TauTheLepton self-assigned this Oct 2, 2024
@TauTheLepton TauTheLepton added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Oct 2, 2024
…o RJD-1057-traffic-lights-tests

Signed-off-by: Mateusz Palczuk <mateusz.palczuk@robotec.ai>
TauTheLepton and others added 2 commits October 10, 2024 13:58
…om-entity-manager' into RJD-1057-traffic-lights-tests

Signed-off-by: Mateusz Palczuk <mateusz.palczuk@robotec.ai>
@dmoszynski dmoszynski self-assigned this Oct 14, 2024
@dmoszynski dmoszynski changed the title [tmp] Remove non-API member functions: EntityManager’s TrafficLight related member functions (tests) [tmp] RJD-1057 (2/5): Remove non-API member functions: EntityManager’s TrafficLight related member functions (tests) Oct 15, 2024
dmoszynski and others added 4 commits November 6, 2024 12:04
…rom-entity-manager' into RJD-1057-traffic-lights-tests
…om-entity-manager' into RJD-1057-traffic-lights-tests

Signed-off-by: Mateusz Palczuk <mateusz.palczuk@robotec.ai>
Copy link

sonarcloud bot commented Nov 7, 2024

@github-actions github-actions bot deleted the branch RJD-1057-remove-traffic-lights-from-entity-manager November 8, 2024 01:25
@github-actions github-actions bot closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants