Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rjd 1278/traffic simulator update #1340

Merged
merged 11 commits into from
Aug 26, 2024
Merged

Conversation

robomic
Copy link
Contributor

@robomic robomic commented Aug 19, 2024

Description

Abstract

This PR contains revisions of the traffic_simulator package unit tests.

Details

Changes are minimal, their main purpose is to unify the source code with previously adopted rules.
Tests have been sorted.
Tests that have been refactored, now contain descriptions.

List of tests updated in this PR:

  1. helper.constructActionStatus
  2. helper.constructLaneletPose
  3. helper.constructRPY
  4. helper.constructRPYfromQuaternion
  5. helper.constructPose
  6. helper.constructLidarConfiguration
  7. helper.constructDetectionSensorConfiguration
  8. SimulationClock.SimulationClock
  9. TrafficLightManager.getTrafficLight
  10. TrafficLightManager.getTrafficLights_setColor
  11. TrafficLightManager.getTrafficLights_setArrow
  12. Color.Color
  13. Color.make
  14. Color.make_wrong
  15. Status.Status
  16. Status.make
  17. Status.make_wrong
  18. Shape.Shape
  19. Shape.make
  20. Shape.make_wrong
  21. Bulb.Bulb
  22. Bulb.make
  23. Bulb.make_wrong
  24. Bulb.operator_TrafficLight
  25. TrafficLight.contains_colorStatusShape
  26. TrafficLight.set_valid

References

Jira ticket: internal link

Destructive Changes

There are no destructive changes.

Copy link

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@robomic
Copy link
Contributor Author

robomic commented Aug 19, 2024

[fixed]
I have encountered an issue with github CI, namely \n is unrecognized. I did not change this file in this PR; last change was made 3 years ago.
Screenshot from 2024-08-19 10-50-22
Screenshot from 2024-08-19 10-51-16
github link

@robomic robomic added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Aug 19, 2024
@hakuturu583 hakuturu583 merged commit b342907 into master Aug 26, 2024
10 checks passed
@github-actions github-actions bot deleted the RJD-1278/traffic_simulator-update branch August 26, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants