-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix longitudinal dintance calculation with lane-change in HdMapUtils::getLongitudinalDistance
#1348
Merged
+60
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
HansRobo
force-pushed
the
fix/distance-with-lane-change
branch
from
August 21, 2024 08:22
0cc8c80
to
0456a52
Compare
HansRobo
added
the
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
label
Aug 21, 2024
HansRobo
changed the title
Fix double counting the second lanelet length following first lanelet with lane-change in
Fix longitudinal dintance calculation with lane-change in Aug 21, 2024
HdMapUtils::getLongitudinalDistance
HdMapUtils::getLongitudinalDistance
HansRobo
added
wait for regression test
bug
Something isn't working
and removed
wait for regression test
labels
Aug 21, 2024
@HansRobo Thank you! |
OK, I'll add C++ unit test |
hakuturu583
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Fix longitudinal dintance calculation with lane-change in
HdMapUtils::getLongitudinalDistance
Details
In previous implementation of
HdMapUtils::getLongitudinalDistance
, the function performed wrong longitudinal distance when the route has a lane change between first and second lanelet.The calculation method is as described in the documentation, but the implementation contained a miss, so I will fix it in this pull-request.
scenario test behavior
I added the bugged case to ByEntityCondition.EntityCondition.DistanceCondition.Shortest.yaml
Before this pull_request, the relative longitudinal distance between Npc1 and Npc4 is calculated to about 113, as executed here.
But after this pull-request, it is calculated to about 54, as defined in the test scenario.
References
Regression Test: OK
Destructive Changes
None
Known Limitations
None