Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rjd 1278/fix isIntersect2D #1350

Closed
wants to merge 2 commits into from
Closed

Conversation

robomic
Copy link
Contributor

@robomic robomic commented Aug 21, 2024

Abstract

Proposition for #1343 fix.

Copy link

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@robomic robomic linked an issue Aug 21, 2024 that may be closed by this pull request
@robomic
Copy link
Contributor Author

robomic commented Aug 23, 2024

Closed in favor of #1353

@robomic robomic closed this Aug 23, 2024
@yamacir-kit yamacir-kit deleted the RJD-1278/fix-1343-isIntersect2D branch September 18, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function isIntersect2D does not handle collinear cases
1 participant