-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use workflow dispatch in docker build #1351
Merged
hakuturu583
merged 27 commits into
master
from
feature/use_workflow_dispatch_in_docker_build
Aug 26, 2024
Merged
use workflow dispatch in docker build #1351
hakuturu583
merged 27 commits into
master
from
feature/use_workflow_dispatch_in_docker_build
Aug 26, 2024
+92
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
…ker_build_by_tag Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
hakuturu583
added
the
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
label
Aug 22, 2024
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
HansRobo
reviewed
Aug 23, 2024
HansRobo
reviewed
Aug 23, 2024
HansRobo
reviewed
Aug 23, 2024
HansRobo
reviewed
Aug 23, 2024
HansRobo
reviewed
Aug 23, 2024
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
HansRobo
approved these changes
Aug 26, 2024
github-actions
bot
deleted the
feature/use_workflow_dispatch_in_docker_build
branch
August 26, 2024 13:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Reduced the execution time of Release workflow.
Background
Release workflow included Docker Build step, which was blocking numerous PRs for longer than necessary.
Details
Separated Release workflow and Docker workflow.
References
The repository has been forked and the modifications have been confirmed to work.
The Docker workflow is failing, but this is because it includes a step to push the image to the GitHub Container Registry of scenario_simulator_v2, and it is deliberately failing as the correct token cannot be provided.
It has been confirmed in the current Release workflow that it works when the correct token is passed.
merge-queue-testing#1
https://github.com/merge-queue-testing/scenario_simulator_v2/actions/runs/10553938073/job/29235018312
Destructive Changes
N/A
Known Limitations
N/A