Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use workflow dispatch in docker build #1351

Merged
merged 27 commits into from
Aug 26, 2024

Conversation

hakuturu583
Copy link
Collaborator

@hakuturu583 hakuturu583 commented Aug 22, 2024

Description

Abstract

Reduced the execution time of Release workflow.

Background

Release workflow included Docker Build step, which was blocking numerous PRs for longer than necessary.

Details

Separated Release workflow and Docker workflow.

  • The Docker workflow is executed through the workflow_dispatch API from within the Release workflow only when the Release workflow runs on the master branch immediately after merge. This triggers the Docker Build and image push.
  • Since workflow_dispatch can also be executed directly from the GitHub UI, it is now possible to manually trigger it in case the Docker Image is not updated due to some error. See also GitHub official document.

References

The repository has been forked and the modifications have been confirmed to work.

The Docker workflow is failing, but this is because it includes a step to push the image to the GitHub Container Registry of scenario_simulator_v2, and it is deliberately failing as the correct token cannot be provided.
It has been confirmed in the current Release workflow that it works when the correct token is passed.

merge-queue-testing#1

https://github.com/merge-queue-testing/scenario_simulator_v2/actions/runs/10553938073/job/29235018312

Destructive Changes

N/A

Known Limitations

N/A

Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
…ker_build_by_tag

Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
@hakuturu583 hakuturu583 added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Aug 22, 2024
@hakuturu583 hakuturu583 self-assigned this Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@hakuturu583 hakuturu583 marked this pull request as ready for review August 23, 2024 08:38
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
hakuturu583 and others added 2 commits August 23, 2024 18:27
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
@hakuturu583 hakuturu583 marked this pull request as draft August 23, 2024 09:54
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
@hakuturu583 hakuturu583 marked this pull request as ready for review August 26, 2024 06:41
@hakuturu583 hakuturu583 merged commit f2d3961 into master Aug 26, 2024
9 checks passed
@github-actions github-actions bot deleted the feature/use_workflow_dispatch_in_docker_build branch August 26, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants