Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RJD-1197/distance #1366

Merged
merged 16 commits into from
Sep 19, 2024
Merged

RJD-1197/distance #1366

merged 16 commits into from
Sep 19, 2024

Conversation

robomic
Copy link
Contributor

@robomic robomic commented Sep 9, 2024

Description

Abstract

This PR contains unit tests for the distance namespace, which is a part of traffic_simulator package.
Additionally:

  • Minor fixes were applied to the distanceToLeftLaneBound and distanceToRightLaneBound.
  • The standard map, which was used extensively, was moved into its own folder, just like the other maps.
  • Minor simplifications in the old hdmap_utils tests.
  • An additional map intersection was added. It contains a large, complex intersection and is convenient in numerous scenarios.

Details

List of tests included in this PR:

  1. distanceTest_FourTrackHighway.lateralDistance_impossible_noChange
  2. distanceTest_FourTrackHighway.lateralDistance_possible_noChange
  3. distanceTest_FourTrackHighway.lateralDistance_impossible_change
  4. distanceTest_FourTrackHighway.lateralDistance_possible_change
  5. distanceTest_FourTrackHighway.lateralDistance_impossible_matching
  6. distanceTest_FourTrackHighway.lateralDistance_possible_matching
  7. distanceTest_FourTrackHighway.longitudinalDistance_noAdjacent_noOpposite_noChange_false
  8. distanceTest_FourTrackHighway.longitudinalDistance_adjacent_noOpposite_noChange_false
  9. distanceTest_FourTrackHighway.longitudinalDistance_adjacent_noOpposite_noChange
  10. distanceTest_FourTrackHighway.longitudinalDistance_noAdjacent_noOpposite_change_false
  11. distanceTest_FourTrackHighway.longitudinalDistance_noAdjacent_noOpposite_change
  12. distanceTest_StandardMap.longitudinalDistance_noAdjacent_noOpposite_noChange
  13. distanceTest_StandardMap.distanceToLeftLaneBound_single
  14. distanceTest_StandardMap.distanceToLeftLaneBound_multipleVector
  15. distanceTest_StandardMap.distanceToLeftLaneBound_singleVector
  16. distanceTest_StandardMap.distanceToLeftLaneBound_emptyVector
  17. distanceTest_Intersection.longitudinalDistance_adjacent_noOpposite_change_false
  18. distanceTest_Intersection.longitudinalDistance_adjacent_noOpposite_change
  19. distanceTest_Intersection.distanceToRightLaneBound_single
  20. distanceTest_Intersection.distanceToRightLaneBound_multipleVector
  21. distanceTest_Intersection.distanceToRightLaneBound_singleVector
  22. distanceTest_Intersection.distanceToRightLaneBound_emptyVector
  23. distance.boundingBoxDistance_intersection
  24. distance.boundingBoxDistance_disjoint

References

Jira ticket: internal link

Destructive Changes

There are no destructive changes.

Regression tests

Jira comment: internal link

Copy link

github-actions bot commented Sep 9, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@robomic robomic self-assigned this Sep 9, 2024
@robomic robomic marked this pull request as ready for review September 9, 2024 13:18
@robomic robomic added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Sep 9, 2024
Copy link
Collaborator

@hakuturu583 hakuturu583 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems, you changed the behavior of the functions in traffic_simulator.
So, please run regression test before pull request open.

@robomic robomic marked this pull request as draft September 10, 2024 08:22
@robomic
Copy link
Contributor Author

robomic commented Sep 12, 2024

Regression tests: internal link

@robomic robomic marked this pull request as ready for review September 12, 2024 11:49
@hakuturu583 hakuturu583 merged commit 54cd077 into master Sep 19, 2024
10 checks passed
@github-actions github-actions bot deleted the RJD-1197/distance branch September 19, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants