Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install add_cpp_mock_scenario_test.cmake first, or colcon build won't pass #1373

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

XiaoyuWang0601
Copy link
Contributor

@XiaoyuWang0601 XiaoyuWang0601 commented Sep 12, 2024

Description

This PR follows with fix/colcon_build_error.

Abstract

There is an error in some environments due to forgetting to write install.

Background

N/A

Details

With a brand new workspace, add_cpp_mock_scenario_test.cmake needs to be installed in CMakeLists.txt first. Or you will have the error below:

CMake Error at /path_to_workspace/install/cpp_mock_scenarios/share/cpp_mock_scenarios/cmake/cpp_mock_scenarios_ament_cmake-extras.cmake:17 (include):
  include could not find requested file:
/path_to_workspace/install/cpp_mock_scenarios/share/cpp_mock_scenarios/cmake/add_cpp_mock_scenario_test.cmake

References

N/A

Destructive Changes

N/A

Known Limitations

N/A

Copy link

github-actions bot commented Sep 12, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@hakuturu583 hakuturu583 added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Sep 12, 2024
@hakuturu583 hakuturu583 merged commit d95790a into master Sep 12, 2024
14 checks passed
@github-actions github-actions bot deleted the fix/colcon_build_error_furthermore branch September 12, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants