Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include #1429

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Add missing include #1429

merged 2 commits into from
Nov 1, 2024

Conversation

TakanoTaiga
Copy link
Member

@TakanoTaiga TakanoTaiga commented Oct 24, 2024

Abstract

This pull request adds missing includes in the files normalize.hpp and execute.cpp.

Background

This update addresses a missing include issue in the geometry/vector3 and concealer namespaces, which caused compilation errors in certain scenarios.

Details

Added the following includes:

  • geometry/vector3/operator.hpp in normalize.hpp
  • rray in execute.cpp

These changes ensure that the necessary headers are included to avoid future compilation issues.

References

This PR fixes errors or warnings that appeared during Clang builds.

Destructive Changes

N/A

Known Limitations

N/A

@TakanoTaiga TakanoTaiga added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Oct 24, 2024
@TakanoTaiga TakanoTaiga self-assigned this Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

Copy link

sonarcloud bot commented Oct 24, 2024

@TakanoTaiga TakanoTaiga marked this pull request as ready for review October 24, 2024 12:54
@TakanoTaiga TakanoTaiga changed the title Add missinginclude Add missing include Oct 24, 2024
@hakuturu583 hakuturu583 merged commit bcdc63b into master Nov 1, 2024
12 checks passed
@github-actions github-actions bot deleted the add-missing-include-2 branch November 1, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants