Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/sonor-cloud-issue #1431

Merged
merged 10 commits into from
Nov 11, 2024
Merged

fix/sonor-cloud-issue #1431

merged 10 commits into from
Nov 11, 2024

Conversation

Copy link

github-actions bot commented Oct 30, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@TakanoTaiga TakanoTaiga changed the title Remove unnecessary const from the return value of the function. fix/sonor-cloud-issue Oct 30, 2024
@TakanoTaiga TakanoTaiga self-assigned this Oct 30, 2024
@TakanoTaiga TakanoTaiga added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Oct 30, 2024
@TakanoTaiga TakanoTaiga marked this pull request as ready for review October 30, 2024 11:43
common/math/geometry/src/bounding_box.cpp Outdated Show resolved Hide resolved
common/math/geometry/include/geometry/bounding_box.hpp Outdated Show resolved Hide resolved
common/math/geometry/src/bounding_box.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@hakuturu583 hakuturu583 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is LGTM.
Start regression test.

Copy link

sonarcloud bot commented Nov 7, 2024

@hakuturu583 hakuturu583 merged commit 5c9c67a into master Nov 11, 2024
16 checks passed
@github-actions github-actions bot deleted the fix/sonor-cloud-issue branch November 11, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants