-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/enable specify entity type in autosink #1443
base: master
Are you sure you want to change the base?
Feature/enable specify entity type in autosink #1443
Conversation
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
@@ -33,6 +35,8 @@ struct Configuration | |||
|
|||
bool auto_sink = true; | |||
|
|||
std::set<traffic_simulator::EntityType, EntityTypeComparator> sinkable_entity_type = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding a less generic type like EntityTypeComparator, change it to add comparison operator overloads to EntityType.
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
Quality Gate passedIssues Measures |
Description
Abstract
Enabled selection of Entity to be Sinked in TrafficSink.
Background
In TrafficSink, arbitrary Entity was despawned when it approached TrafficSink, so there were cases where EgoEntity was despawned and testing could not continue.
Details
To enable this feature, set auto_sink, a member of
traffic_simulator::Configuration
structure, to true, and setstd::set<traffic_simulator::EntityType, traffic_ simulator::EntityTypeComparator>
to specify the target EntityType of the entity to be despawned.e.g
References
N/A
Destructive Changes
N/A
Known Limitations