Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preprocessor,interpreter): support ParameterValueDistribution #878

Closed
wants to merge 168 commits into from

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Sep 13, 2022

Types of PR

  • New Features
  • Upgrade of existing features
  • Bugfix

Link to the issue

Description

  • Support ParameterValueDistribution
    • except UserDefinedValueDistribution
  • Add C++ implementation of XML validation
  • Divide ROS interface in openscenario_preprocessor package

Note

The following points are not covered by this pull-request

  • Enable parallel execution of parameter derivation
    • overload ofderive and getNumberOfDeriveScenarios are experimental implementation
  • Delete the python implementation of XML validation and unified to its C++ implementation
  • Delete ROS from dependencies of openscenario_preprocessor/openscenario_preprocessor.cpp completely
    • To achieve this, we must delete ROS fom openscenario_interpreter::OpenScenario class
    • This will be supported in next pull-request.

How to review this PR.

Others

Operation Checking for openscenario_preprocessor

  • Deterministic.DistributionRange.xosc
  • Deterministic.DistributionSet.xosc
  • Deterministic.ValueSetDistribution.xosc
  • Stochastic.Histogram.xosc
  • Stochastic.NormalDistribution.xosc
  • Stochastic.LogNormalDistribution.xosc
  • Stochastic.PoissonDistribution.xosc
  • Stochastic.ProbabilityDistributionSet.xosc
  • Stochastic.UniformDistribution.xosc

Results of Sample Scenarios

openscenario_preprocessor.zip

@HansRobo HansRobo added the feature New feature or request label Sep 13, 2022
@HansRobo HansRobo self-assigned this Sep 13, 2022
@HansRobo HansRobo changed the title Feature/parameter value distribution feat(preprocessor,interpreter): support ParameterValueDistribution Nov 8, 2022
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…feature/parameter_value_distribution

# Conflicts:
#	openscenario/openscenario_interpreter/include/openscenario_interpreter/random/stochastic_distribution_sampler.hpp
#	openscenario/openscenario_interpreter/src/syntax/histogram.cpp
#	openscenario/openscenario_interpreter/src/syntax/normal_distribution.cpp
#	openscenario/openscenario_interpreter/src/syntax/poisson_distribution.cpp
#	openscenario/openscenario_interpreter/src/syntax/probability_distribution_set.cpp
#	openscenario/openscenario_interpreter/src/syntax/uniform_distribution.cpp
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…alue_distribution

# Conflicts:
#	openscenario/openscenario_interpreter/include/openscenario_interpreter/random/stochastic_distribution_sampler.hpp
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…chastic parameter distributions

Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…::derive()

Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…:derive()

Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@HansRobo HansRobo closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 feature New feature or request wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants