7.4.4
Description
Abstract
The package concealer code was refactored. (continuation of #1488.)
Background
See #1488 description.
Details
Reducing Member Functions
Several member functions were removed for the same purpose as in #1488. Below is the background and policy for this as described in #1488.
Member functions that are only used by certain member functions have been changed to function local functions. Making them private member functions was also an option, but we decided not to do so. Based on our experience in maintenance over the past few years, the cost of understanding where a certain member function is being called from is a burden both in terms of code modification and code review. This is just a matter of preference. I don't mind changing function-local functions to private member functions at some point, so I'm doing it this way for now to make refactoring following this pull request easier.
References
Destructive Changes
None.
Known Limitations
None.