-
Notifications
You must be signed in to change notification settings - Fork 134
[RS-2577] Mention new GatewayAPI customization fields #2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
LGTM. Do these need to be moved also to OSS and CC? |
|
Thanks @ctauchen . At time of writing this was intended for Enterprise and Cloud only, but the requirements position has changed and the changes should now be for OSS as well. So I will copy the changes across to OSS and CC. |
|
@ctauchen I've just remembered that I meant to tag @apardeshi-tigera also to take a look at these docs. So let's hold off on merging until he has done that. |
| To make use of these customization fields, use `kubectl edit gatewayapi default` to edit the YAML for the `GatewayAPI` resource, and add or modify the customization fields that you require. | ||
| ### Configure additional GatewayClasses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nelljerram Why are we taking this out? This section is already live in the 3.30 docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we now have an official way to provision additional GatewayClasses, using the spec.gatewayClasses field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course -- let me check where we are with Ash and we'll get this sorted out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @ctauchen .
|
@nelljerram I got the thumbs-up from Ash. If you can squash and sort your merge conflict, we can get this merged today. |
|
@ctauchen Conflict is done. Is squashing essential? Personally I dislike it because it destroys the history of the conversation. But will if you insist. (Also not a fan of squash-merging because that leaves a branch in my local repo that appears to be unmerged - but I feel I'm losing the battle on that one.) |
|
@nelljerram @ctauchen Section title: Gateway Customization: |
|
@apardeshi-tigera The convention for section title is that it's a sentence beginning with an imperative verb, so I think we should stick to that. For your "Overview", I think the only point that is not already covered is that it's done through a single GatewayAPI resource. If that's right, I'll propose a change to incorporate that. For the Examples - yes, great idea to add those; I'll propose that shortly. |
|
@apardeshi-tigera I've updated the PR per your comments now. Can you take another look at the calico-docs-preview-next preview and LMK what you think? |
|
Looks good |

No description provided.