Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSS CAN driver #337

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Add MSS CAN driver #337

merged 1 commit into from
Mar 24, 2025

Conversation

haitomatic
Copy link

@haitomatic haitomatic commented Jan 9, 2025 •
edited
Loading

  • Add MSS CAN driver to support MSS CAN pheripheral

Passed the classical CAN and CAN ID filter tests from https://github.com/tiiuae/mpfs_canfd_uavcan_example

Result file: canfd_test_result.txt

@haitomatic haitomatic marked this pull request as draft January 9, 2025 13:34
@haitomatic haitomatic force-pushed the SSRCDP-10527_CAN_MSS_support branch from 601f100 to 17d7f06 Compare March 11, 2025 13:09
@haitomatic haitomatic marked this pull request as ready for review March 11, 2025 13:17
@haitomatic haitomatic requested a review from jpaali March 11, 2025 13:18
@jpaali jpaali requested a review from jlaitine March 11, 2025 13:36
@haitomatic haitomatic force-pushed the SSRCDP-10527_CAN_MSS_support branch from 17d7f06 to 2bb870d Compare March 11, 2025 14:00
jpaali
jpaali reviewed Mar 11, 2025
View reviewed changes
Copy link

@jpaali jpaali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just took a quick look at this point.. looks good but need to take a closer look later

@jlaitine
Copy link

Looking good in general, I added a few questions and comments!

@haitomatic haitomatic force-pushed the SSRCDP-10527_CAN_MSS_support branch 2 times, most recently from 2aa2408 to 24407d4 Compare March 16, 2025 20:49
@haitomatic haitomatic force-pushed the SSRCDP-10527_CAN_MSS_support branch 2 times, most recently from cc0ac79 to 2ed5e70 Compare March 17, 2025 14:46
@haitomatic haitomatic requested review from jlaitine and jpaali March 17, 2025 14:48
@haitomatic haitomatic force-pushed the SSRCDP-10527_CAN_MSS_support branch from 25e9f1c to 900f37f Compare March 17, 2025 14:59
@jlaitine
Copy link

Please don't delete the canfd defconfig in this PR; instead, select this in icicle/hwtest defconfig to compile it in!

@haitomatic
Copy link
Author

transfered for testing in PMK now

@haitomatic haitomatic force-pushed the SSRCDP-10527_CAN_MSS_support branch 4 times, most recently from 112b3d2 to fac8983 Compare March 20, 2025 08:54
jlaitine
jlaitine approved these changes Mar 21, 2025
View reviewed changes
Copy link

@jlaitine jlaitine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After this has been tested to work, please send to upstream nuttx as well, since can2.0b controller is part of mpfs soc.

@haitomatic haitomatic force-pushed the SSRCDP-10527_CAN_MSS_support branch from fac8983 to c28c64f Compare March 23, 2025 20:26
@haitomatic haitomatic force-pushed the SSRCDP-10527_CAN_MSS_support branch from c28c64f to dc3b8aa Compare March 23, 2025 20:30
@haitomatic haitomatic merged commit 720284c into master Mar 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaitine jlaitine jlaitine approved these changes

@jpaali jpaali Awaiting requested review from jpaali

Assignees
No one assigned
Labels
Arch: risc-v Board: risc-v Size: XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haitomatic @jlaitine @jpaali