Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the async broadcast & resolveFlushedLocks #1493

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Nov 13, 2024

  1. Fix the potential data race caused by a mix use of go and spawnWithStorePool. Close data race in TestPipelinedDMLInsertOnDuplicateKeyUpdateInTxn pingcap/tidb#57213
  2. Make the broadcast in Rollback async to reduce the wait in Rollback operations.

…llback async

Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2024
@ekexium ekexium changed the title Fix the async broadcast Fix the async broadcast & resolveFlushedLocks Nov 13, 2024
@ekexium ekexium requested a review from you06 November 13, 2024 05:55
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 14, 2024
Copy link

ti-chi-bot bot commented Nov 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-14 04:12:47.154369702 +0000 UTC m=+502329.345238700: ☑️ agreed by cfzjywxk.

Copy link

ti-chi-bot bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data race in TestPipelinedDMLInsertOnDuplicateKeyUpdateInTxn
2 participants