Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #350] Fix flaky it http_api #351

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

pingyu
Copy link
Collaborator

@pingyu pingyu commented Aug 25, 2023

What problem does this PR solve?

Issue Number: close #issue_number

Problem Description: TBD

What is changed and how does it work?

The issus seems to be caused by tikv-server OOM killed.

Reduce memory usage by specify small capacity of block cache and reduce number of tikv-server instantce.

Code changes

  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Integration test

Side effects

  • No side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note
  • No related changes

To reviewers

Please follow these principles to check this pull requests:

  • Concentration. One pull request should only do one thing. No matter how small it is, the change does exactly one thing and gets it right. Don't mix other changes into it.
  • Tests. A pull request should be test covered, whether the tests are unit tests, integration tests, or end-to-end tests. Tests should be sufficient, correct and don't slow down the CI pipeline largely.
  • Functionality. The pull request should implement what the author intends to do and fit well in the existing code base, resolve a real problem for TiDB/TiKV users. To get the author's intention and the pull request design, you could follow the discussions in the corresponding GitHub issue or internal.tidb.io topic.
  • Style. Code in the pull request should follow common programming style. (For Go, we have style checkers in CI). However, sometimes the existing code is inconsistent with the style guide, you should maintain consistency with the existing code or file a new issue to fix the existing code style first.
  • Documentation. If a pull request changes how users build, test, interact with, or release code, you must check whether it also updates the related documentation such as READMEs and any generated reference docs. Similarly, if a pull request deletes or deprecates code, you must check whether or not the corresponding documentation should also be deleted.
  • Performance. If you find the pull request may affect performance, you could ask the author to provide a benchmark result.

(The above text mainly refers to TiDB Development Guide. It's also highly recommended to read about Writing code review comments)

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #351 (ba225c0) into main (c340278) will increase coverage by 0.1699%.
Report is 1 commits behind head on main.
The diff coverage is 63.7500%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main       #351        +/-   ##
================================================
+ Coverage   61.1272%   61.2972%   +0.1699%     
================================================
  Files           240        241         +1     
  Lines         20261      20412       +151     
================================================
+ Hits          12385      12512       +127     
- Misses         6758       6759         +1     
- Partials       1118       1141        +23     
Flag Coverage Δ *Carryforward flag
br 60.6802% <ø> (ø) Carriedforward from e46a07a
cdc 61.5796% <63.7500%> (+0.2455%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
cdc/cdc/kv/metrics.go 0.0000% <0.0000%> (ø)
cdc/cdc/processor/pipeline/keyspan.go 0.0000% <0.0000%> (ø)
cdc/cdc/processor/pipeline/puller.go 0.0000% <0.0000%> (ø)
cdc/pkg/config/replica_config.go 63.2653% <0.0000%> (-5.6236%) ⬇️
cdc/pkg/util/ctx.go 76.4705% <0.0000%> (-12.1658%) ⬇️
cdc/cdc/kv/region_worker.go 78.6885% <33.3333%> (-0.8949%) ⬇️
cdc/pkg/cmd/cli/cli_changefeed_update.go 28.2051% <66.6666%> (+2.9877%) ⬆️
cdc/pkg/util/kv_filter.go 91.6666% <91.6666%> (ø)
cdc/cdc/kv/client.go 83.8848% <100.0000%> (-2.1382%) ⬇️

... and 15 files with indirect coverage changes

@pingyu
Copy link
Collaborator Author

pingyu commented Aug 25, 2023

/run-integration-test

2 similar comments
@pingyu
Copy link
Collaborator Author

pingyu commented Aug 25, 2023

/run-integration-test

@pingyu
Copy link
Collaborator Author

pingyu commented Aug 25, 2023

/run-integration-test

Copy link
Contributor

@zeminzhou zeminzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@pingyu pingyu merged commit 95dc443 into tikv:main Aug 25, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants