-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[close #371] Upgrade client-go/tidb to release 7.5 #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ping Yu <yuping@pingcap.com>
pingyu
force-pushed
the
upgrade-client-go-7.5
branch
from
December 2, 2023 09:17
f14febf
to
16d1c27
Compare
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
================================================
+ Coverage 61.6247% 61.8268% +0.2020%
================================================
Files 240 241 +1
Lines 20052 20221 +169
================================================
+ Hits 12357 12502 +145
- Misses 6578 6579 +1
- Partials 1117 1140 +23
*This pull request uses carry forward flags. Click here to find out more.
|
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
zeminzhou
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #371
Problem Description: Fail to bump grpc 1.59
grpc 1.59 move the path of package
google.golang.org/grpc/test/grpc_testing
, which is required bygithub.com/pingcap/tidb/store/mockstore
->go.etcd.io/etcd/pkg/v3/grpc_testing
.So upgrade dependency of TiDB to solve this issue.
What is changed and how does it work?
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes
To reviewers
Please follow these principles to check this pull requests:
(The above text mainly refers to TiDB Development Guide. It's also highly recommended to read about Writing code review comments)