tso: add retry for UpdateTSO #9021

lhy1024 · 2025-01-26T03:24:01Z

What problem does this PR solve?

Issue Number: Close #9020

What is changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
Before:

After:

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>

codecov · 2025-01-26T03:30:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.24%. Comparing base (dcb426b) to head (ebbb024).
Report is 1435 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9021      +/-   ##
==========================================
+ Coverage   75.54%   76.24%   +0.69%     
==========================================
  Files         332      467     +135     
  Lines       33892    71113   +37221     
==========================================
+ Hits        25604    54218   +28614     
- Misses       6082    13510    +7428     
- Partials     2206     3385    +1179

Flag	Coverage Δ
unittests	`76.24% <100.00%> (+0.69%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: lhy1024 <admin@liudos.us>

pkg/tso/global_allocator.go

Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot · 2025-02-05T07:33:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nolouch,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-02-05T07:33:02Z

[LGTM Timeline notifier]

Timeline:

2025-02-05 02:58:33.033534029 +0000 UTC m=+240584.565946028: ☑️ agreed by nolouch.
2025-02-05 07:33:01.936845935 +0000 UTC m=+257053.469257934: ☑️ agreed by rleungx.

lhy1024 · 2025-02-05T07:38:57Z

I will test it with new commit

lhy1024 · 2025-02-05T10:46:05Z

/hold

lhy1024 · 2025-02-05T13:46:02Z

it is also stable with new hash

https://tcms.pingcap.net/dashboard/executions/plan/7816929

https://tcms.pingcap.net/dashboard/executions/plan/7816937

lhy1024 · 2025-02-11T07:37:36Z

/run-check-issue-triage-complete

lhy1024 · 2025-02-11T07:37:59Z

/cherry-pick release-6.5

close tikv#9020 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2025-02-11T07:38:36Z

@lhy1024: new pull request created to branch release-6.5: #9062.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

lhy1024 · 2025-02-11T07:39:11Z

/cherry-pick release-7.5

close tikv#9020 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2025-02-11T07:39:48Z

@lhy1024: new pull request created to branch release-7.5: #9063.
But this PR has conflicts, please resolve them!

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close tikv#9020 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2025-02-11T07:41:37Z

In response to a cherrypick label: new pull request created to branch release-7.1: #9064.
But this PR has conflicts, please resolve them!

ti-chi-bot · 2025-02-11T07:41:37Z

In response to a cherrypick label: new pull request created to branch release-8.1: #9065.
But this PR has conflicts, please resolve them!

close tikv#9020 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2025-02-11T07:41:38Z

In response to a cherrypick label: new pull request created to branch release-8.5: #9066.

close #9020 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <liuhanyang@pingcap.com> Co-authored-by: lhy1024 <admin@liudos.us>

close #9020 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <liuhanyang@pingcap.com> Co-authored-by: lhy1024 <admin@liudos.us> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

close #9020 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <admin@liudos.us> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

close #9020 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <liuhanyang@pingcap.com> Co-authored-by: lhy1024 <admin@liudos.us>

tso: add retry for UpdateTSO

ea4f3f0

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 requested a review from rleungx January 26, 2025 03:24

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 26, 2025

fix lint

c01a203

Signed-off-by: lhy1024 <admin@liudos.us>

nolouch approved these changes Feb 5, 2025

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 5, 2025

rleungx reviewed Feb 5, 2025

View reviewed changes

pkg/tso/global_allocator.go Outdated Show resolved Hide resolved

update interval

a557b40

Signed-off-by: lhy1024 <admin@liudos.us>

rleungx approved these changes Feb 5, 2025

View reviewed changes

ti-chi-bot bot added the lgtm label Feb 5, 2025

ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 5, 2025

Merge branch 'master' into etcd-keep

51ea902

Merge branch 'master' into etcd-keep

ebbb024

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2025

lhy1024 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2025

ti-chi-bot bot merged commit ac4e640 into tikv:master Feb 5, 2025
25 checks passed

lhy1024 deleted the etcd-keep branch February 5, 2025 13:48

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 11, 2025

This is an automated cherry-pick of tikv#9021

9ee74e6

close tikv#9020 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Feb 11, 2025

tso: add retry for UpdateTSO (#9021) #9062

Merged

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 11, 2025

This is an automated cherry-pick of tikv#9021

2ee7f8a

close tikv#9020 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Feb 11, 2025

tso: add retry for UpdateTSO (#9021) #9063

Merged

ti-chi-bot bot added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Feb 11, 2025

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 11, 2025

This is an automated cherry-pick of tikv#9021

9fed45d

close tikv#9020 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 11, 2025

This is an automated cherry-pick of tikv#9021

55a8d82

close tikv#9020 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

This was referenced Feb 11, 2025

tso: add retry for UpdateTSO (#9021) #9064

Merged

tso: add retry for UpdateTSO (#9021) #9065

Merged

ti-chi-bot mentioned this pull request Feb 11, 2025

tso: add retry for UpdateTSO (#9021) #9066

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tso: add retry for UpdateTSO #9021

tso: add retry for UpdateTSO #9021

lhy1024 commented Jan 26, 2025

codecov bot commented Jan 26, 2025 •

edited

Loading

ti-chi-bot bot commented Feb 5, 2025

ti-chi-bot bot commented Feb 5, 2025

lhy1024 commented Feb 5, 2025

lhy1024 commented Feb 5, 2025

lhy1024 commented Feb 5, 2025 •

edited

Loading

lhy1024 commented Feb 11, 2025

lhy1024 commented Feb 11, 2025

ti-chi-bot commented Feb 11, 2025

lhy1024 commented Feb 11, 2025

ti-chi-bot commented Feb 11, 2025

ti-chi-bot commented Feb 11, 2025

ti-chi-bot commented Feb 11, 2025

ti-chi-bot commented Feb 11, 2025

tso: add retry for UpdateTSO #9021

tso: add retry for UpdateTSO #9021

Conversation

lhy1024 commented Jan 26, 2025

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

codecov bot commented Jan 26, 2025 • edited Loading

Codecov Report

ti-chi-bot bot commented Feb 5, 2025

ti-chi-bot bot commented Feb 5, 2025

[LGTM Timeline notifier]

lhy1024 commented Feb 5, 2025

lhy1024 commented Feb 5, 2025

lhy1024 commented Feb 5, 2025 • edited Loading

lhy1024 commented Feb 11, 2025

lhy1024 commented Feb 11, 2025

ti-chi-bot commented Feb 11, 2025

lhy1024 commented Feb 11, 2025

ti-chi-bot commented Feb 11, 2025

ti-chi-bot commented Feb 11, 2025

ti-chi-bot commented Feb 11, 2025

ti-chi-bot commented Feb 11, 2025

codecov bot commented Jan 26, 2025 •

edited

Loading

lhy1024 commented Feb 5, 2025 •

edited

Loading