Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add metrics for the internal pd client calls #9043

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 7, 2025

What problem does this PR solve?

Issue Number: Close #9039

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.28%. Comparing base (d9abd06) to head (4dcadb4).
Report is 1430 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9043      +/-   ##
==========================================
+ Coverage   75.65%   76.28%   +0.62%     
==========================================
  Files         332      467     +135     
  Lines       33902    71149   +37247     
==========================================
+ Hits        25650    54276   +28626     
- Misses       6056    13494    +7438     
- Partials     2196     3379    +1183     
Flag Coverage Δ
unittests 76.28% <100.00%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 7, 2025
@rleungx rleungx requested a review from JmPotato February 8, 2025 04:12
Copy link
Contributor

ti-chi-bot bot commented Feb 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 8, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-07 11:39:29.332977019 +0000 UTC m=+11011.729199076: ☑️ agreed by lhy1024.
  • 2025-02-08 06:30:22.775549554 +0000 UTC m=+78865.171771614: ☑️ agreed by JmPotato.

@ti-chi-bot ti-chi-bot bot merged commit ce76161 into tikv:master Feb 8, 2025
26 checks passed
@rleungx rleungx deleted the add-internal-metrics branch February 8, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetMembers metrics are missing on the client side
3 participants