Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: completely remove the deprecated field from the PD server config (#8981) #9059

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8981

What problem does this PR solve?

Issue Number: Close #8980

What is changed and how does it work?

server/config: completely remove the deprecated field from the PD server config

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

From 7.1.1 to master:
image

master restart twice:
image

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

close tikv#8980

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 11, 2025
@ti-chi-bot
Copy link
Member Author

@nolouch This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 11, 2025
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch force-pushed the cherry-pick-8981-to-release-7.5 branch from 34ae185 to 0a18678 Compare February 12, 2025 06:17
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 12, 2025
@rleungx
Copy link
Member

rleungx commented Feb 12, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2025
@rleungx rleungx requested a review from lhy1024 February 12, 2025 06:58
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 12, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-12 06:58:40.042203311 +0000 UTC m=+426162.438425373: ☑️ agreed by rleungx.
  • 2025-02-12 06:59:55.325527279 +0000 UTC m=+426237.721749337: ☑️ agreed by lhy1024.

Copy link
Contributor

ti-chi-bot bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, niubell, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 12, 2025
@rleungx
Copy link
Member

rleungx commented Feb 12, 2025

/retest

Copy link
Contributor

ti-chi-bot bot commented Feb 12, 2025

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@rleungx
Copy link
Member

rleungx commented Feb 12, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 370c4ce into tikv:release-7.5 Feb 12, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants