Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add QueryRegion related metrics #9076

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JmPotato
Copy link
Member

Signed-off-by: JmPotato ghzpotato@gmail.com

What problem does this PR solve?

Issue Number: ref #8690.

What is changed and how does it work?

Add QueryRegion related metrics.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
图片

Release note

None.

@JmPotato JmPotato added the component/metrics Metrics. label Feb 12, 2025
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Feb 12, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jmpotato, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 12, 2025
@JmPotato JmPotato force-pushed the query_region_metrics branch 2 times, most recently from 1117b90 to 6b9ccfc Compare February 14, 2025 06:24
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the query_region_metrics branch from 6b9ccfc to d3f326b Compare February 14, 2025 06:25
Copy link
Contributor

ti-chi-bot bot commented Feb 14, 2025

@JmPotato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-realcluster-test d3f326b link true /test pull-integration-realcluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 96.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.24%. Comparing base (b7977dd) to head (d3f326b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9076      +/-   ##
==========================================
+ Coverage   76.20%   76.24%   +0.04%     
==========================================
  Files         468      468              
  Lines       71471    71549      +78     
==========================================
+ Hits        54462    54556      +94     
+ Misses      13595    13587       -8     
+ Partials     3414     3406       -8     
Flag Coverage Δ
unittests 76.24% <96.42%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics Metrics. dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant