Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TiKV IO rate limiter #383

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

v01dstar
Copy link

Cherry-picking of #216

Adding FileSystemInspectedEnv, so that IO operations can be inspected and controlled by inspector in TiKV. This is the backbone of tikv.storage.io-rate-limit

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 27, 2024
@v01dstar v01dstar force-pushed the tikv-io-rate-limiter branch from 1d83b92 to 314b9d6 Compare September 27, 2024 07:17
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 27, 2024
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@v01dstar v01dstar force-pushed the tikv-io-rate-limiter branch from 314b9d6 to 092c0d9 Compare September 27, 2024 07:42
Copy link

ti-chi-bot bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, LykxSassinator

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Connor1996,LykxSassinator]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 27, 2024
Copy link

ti-chi-bot bot commented Sep 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-27 07:41:16.245907877 +0000 UTC m=+1810945.986331817: ☑️ agreed by Connor1996.
  • 2024-09-27 07:48:00.592199176 +0000 UTC m=+1811350.332623117: ☑️ agreed by LykxSassinator.

@ti-chi-bot ti-chi-bot bot merged commit d308a00 into tikv:8.10.tikv Sep 27, 2024
5 checks passed
@v01dstar v01dstar deleted the tikv-io-rate-limiter branch October 9, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants