[Fix][Debug] Fix source code mapping in submodule#20
Open
oraluben wants to merge 1 commit intotile-ai:tilelang_mainfrom
Open
[Fix][Debug] Fix source code mapping in submodule#20oraluben wants to merge 1 commit intotile-ai:tilelang_mainfrom
oraluben wants to merge 1 commit intotile-ai:tilelang_mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original setting tries to set absolute path when building a debug tvm, so that debugger will be able to locate source file. However this seems wrong when building tvm as a submodule: lldb will look for wrong file.
With this PR, the source file could be founded without manually mapping.
I also tried
set(FILE_PREFIX_MAP_FLAG "-ffile-prefix-map=../../..=${CMAKE_CURRENT_SOURCE_DIR}")but it doesn't work.This chang is very limited to tilelang and ad-hoc, and does not suite for upstream tvm. Also open for some better fix cc @Hzfengsy
Also this seems a lldb-specific issue.